Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Burst limit for discovery client #86168

Merged
merged 1 commit into from Dec 11, 2019
Merged

Increase Burst limit for discovery client #86168

merged 1 commit into from Dec 11, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 11, 2019 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Increases default burst value for discovery client.

Which issue(s) this PR fixes:
Fixes #86149

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Resolves performance regression in `kubectl get all` and in client-go discovery clients constructed using `NewDiscoveryClientForConfig` or `NewDiscoveryClientForConfigOrDie`.

/cc @smarterclayton

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 11, 2019
liggitt
liggitt commented Dec 11, 2019
View reviewed changes
staging/src/k8s.io/client-go/discovery/discovery_client_test.go
serverResources, err := client.ServerResources()
if err != nil {
t.Errorf("unexpected error: %v", err)
}
end := time.Now()
if d := end.Sub(start); d > time.Second {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This took ~2 seconds before the fix, and 2ms after.

@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 11, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 11, 2019
@liggitt liggitt force-pushed the discovery-burst branch 2 times, most recently from d989723 to 0451e6f Compare December 11, 2019 16:52
This was referenced Dec 11, 2019
Merged
Closed
@smarterclayton
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [liggitt,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2019
@liggitt
Copy link
Member Author

liggitt commented Dec 11, 2019

fixed spelling error, retagged

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0d58709 into kubernetes:master Dec 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 11, 2019
@liggitt liggitt deleted the discovery-burst branch December 12, 2019 16:51
k8s-ci-robot added a commit that referenced this pull request Dec 15, 2019
@k8s-ci-robot
Merge pull request #86170 from liggitt/automated-cherry-pick-of-#8616…
484b5f9 
…8-upstream-release-1.17

[1.17.1] Automated cherry pick of #86168: Increase Burst limit for discovery client
@liggitt liggitt mentioned this pull request Dec 20, 2019
Closed
@msau42 msau42 mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

k8s v1.17.0 (client-go v0.17.0) DiscoveryClient throttled
3 participants
@liggitt @smarterclayton @k8s-ci-robot