Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore IPAllocator ipv4 range handling #86534

Merged
merged 2 commits into from Dec 23, 2019
Merged

Restore IPAllocator ipv4 range handling #86534

merged 2 commits into from Dec 23, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 23, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Reverts the IP allocator portions of #83422, adds unit test covering #86497 scenario

Which issue(s) this PR fixes:
Fixes #86497

Does this PR introduce a user-facing change?:

Fixes v1.17.0 regression in --service-cluster-ip-range handling with IPv4 ranges larger than 65536 IP addresses

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 23, 2019
@liggitt
Copy link
Member Author

liggitt commented Dec 23, 2019

/sig network
/cc @yastij

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 23, 2019
@liggitt
Copy link
Member Author

liggitt commented Dec 23, 2019

/priority critical-urgent
/milestone v1.17

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Dec 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Dec 23, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2019
@liggitt liggitt mentioned this pull request Dec 23, 2019
Merged
@liggitt
Copy link
Member Author

liggitt commented Dec 23, 2019

/hold for network review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2019
@neolit123
Copy link
Member

neolit123 commented Dec 23, 2019 •
edited

LGTM, thanks.

as part of #83422:

https://github.com/kubernetes/kubernetes/pull/83422/files#diff-8901e0d89ec6745ac599b98964928090R388
https://github.com/kubernetes/kubernetes/pull/83422/files#diff-8901e0d89ec6745ac599b98964928090R400

are not very problematic as the clamped results only compare to the constant 10.
can be fixed in a separate PR in master and a backport is not needed.

i will log an issue in k/kubeadm for that.
EDIT: kubernetes/kubeadm#1985

@neolit123 neolit123 mentioned this pull request Dec 23, 2019
Closed
@liggitt
Copy link
Member Author

liggitt commented Dec 23, 2019

Yeah, I swept the other uses and they looked to be done only for validation against much smaller ranges

yastij
yastij reviewed Dec 23, 2019
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
@liggitt
Copy link
Member Author

liggitt commented Dec 23, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt
Copy link
Member Author

liggitt commented Dec 23, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5e31799 into kubernetes:master Dec 23, 2019
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Dec 23, 2019
k8s-ci-robot added a commit that referenced this pull request Dec 25, 2019
@k8s-ci-robot
Merge pull request #86535 from liggitt/automated-cherry-pick-of-#8653…
e9d861d 
…4-upstream-release-1.17

[v1.17.1] Automated cherry pick of #86534: Revert "remove ipallocator in favor of k/utils net
@liggitt liggitt deleted the ipallocator-range branch December 26, 2019 18:00
@neolit123 neolit123 mentioned this pull request Jan 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij yastij left review comments

@deads2k deads2k Awaiting requested review from deads2k

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Service is not within the service CIDR please recreate
5 participants
@liggitt @k8s-ci-robot @neolit123 @fejta-bot @yastij