RemainingItemCount is serialized in proto messages even when unset #78318
Labels
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone
What happened:
As part of adding skew testing for serialized API responses, we discovered a diff in serialized proto responses when roundtripping data from 1.14:
This is due to the RemainingItemCount field in ListMeta, which is always serialized in proto messages, because it is not a pointer.
What you expected to happen:
Proto messages do not include the optional field when unset.
How to reproduce it (as minimally and precisely as possible):
go test ./vendor/k8s.io/api -run TestRoundTripExternalTypes//1.14
(tests round-tripping serialized API content for all types we shipped in 1.14)This needs to be resolved before 1.15 ships.
/milestone v1.15
/kind bug
/sig api-machinery
/priority important-soon
/assign @caesarxuchao
The text was updated successfully, but these errors were encountered: