Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump metadata-proxy to v0.1.11, update tests & test image #71094

Merged
merged 1 commit into from Dec 18, 2018
Merged

bump metadata-proxy to v0.1.11, update tests & test image #71094

merged 1 commit into from Dec 18, 2018

Conversation

dekkagaijin
Copy link
Contributor

@dekkagaijin dekkagaijin commented Nov 15, 2018 •
edited

Picks up GoogleCloudPlatform/k8s-metadata-proxy#26

@mikedanese PTAL

/kind bug

In addition to restricting GCE metadata requests to known APIs, the metadata-proxy now restricts query strings to known parameters.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 15, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @dekkagaijin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 15, 2018
@mikedanese
Copy link
Member

/ok-to-test
/sig gcp
/priority important-soon

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/gcp priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 15, 2018
@mikedanese
Copy link
Member

@dekkagaijin tests are broke.

@dekkagaijin
Copy link
Contributor Author

The tests should get a job and stop making us working folk deal with their failures.

@cjcullen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@cjcullen cjcullen added this to the v1.13 milestone Nov 16, 2018
@cjcullen
Copy link
Member

/approve

@cjcullen
Copy link
Member

/retest

@ixdy
Copy link
Member

ixdy commented Nov 16, 2018

/approve
/retest

@ixdy
Copy link
Member

ixdy commented Nov 16, 2018

/approve
/retest

webhook dropped?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjcullen, dekkagaijin, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@mikedanese mikedanese removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@ixdy
Copy link
Member

ixdy commented Nov 16, 2018

[sig-auth] Metadata Concealment should run a check-metadata-concealment job to completion failed, which seems problematic?

@dekkagaijin
Copy link
Contributor Author

@ixdy yeah, looks like there's no insight into the failure in the logs, so I'll have to get a test cluster setup myself

@nikopen
Copy link
Contributor

nikopen commented Nov 19, 2018 •
edited

@dekkagaijin @ixdy Is this critical for 1.13 GCE? If not, it should be moved out to a patch release

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 19, 2018
@AishSundar
Copy link
Contributor

@ixdy @dekkagaijin is this needed for 1.13? We are code freeze and I rather wait to take this in for 1.14 if its not critical

/remove-priority critical-urgent

@k8s-ci-robot k8s-ci-robot removed the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 19, 2018
@dekkagaijin
Copy link
Contributor Author

Is master a sensitive branch?

@dekkagaijin
Copy link
Contributor Author

Not critical

@nikopen
Copy link
Contributor

nikopen commented Nov 19, 2018

master will become 1.13.0 in a few weeks, and PRs to master are gatekeeped just before the release. Let's move this to post release so it merges for 1.13.1 or others

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.13 milestone Nov 19, 2018
@dekkagaijin
Copy link
Contributor Author

Anything works, I'll keep an eye on this PR

@dekkagaijin
Copy link
Contributor Author

Pinging this again now that 1.13 is out

@cjcullen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2018
@dekkagaijin
Copy link
Contributor Author

/retest pull-kubernetes-godeps

@dekkagaijin
Copy link
Contributor Author

/retest

@dekkagaijin
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

1 similar comment
@dekkagaijin
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot merged commit 12be140 into kubernetes:master Dec 18, 2018
@dekkagaijin dekkagaijin mentioned this pull request Jan 30, 2019
Closed
@dekkagaijin dekkagaijin mentioned this pull request Apr 23, 2019
Closed
@dekkagaijin dekkagaijin deleted the update-concealment branch April 20, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcullen cjcullen Awaiting requested review from cjcullen

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@cjcullen cjcullen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dekkagaijin @k8s-ci-robot @mikedanese @cjcullen @nikopen @ixdy @fejta-bot @AishSundar