Modify Event struct to allow compressing multiple recurring events in to a single event #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| InitialTimestamp util.Time `json:"initialTimestamp,omitempty"` | ||
|
|
||
| // The time at which the most recent occurance of this event was recorded. | ||
| LastSeenTimestamp util.Time `json:"initialTimestamp,omitempty"` |
… to a single event. # *** ERROR: *** Some API files are missing the required field descriptions # Add description tags to all non-inline fields in the following files: # pkg/api/v1beta1/types.go # pkg/api/v1beta2/types.go # # Your commit will be aborted unless you fix these. # COMMIT_BLOCKED_ON_DESCRIPTION
saad-ali
force-pushed
the
modifyEventStruct
branch
from
c0362a7
to
79cbcf9
Compare
|
Feedback addressed. Comments in line. PTAL. |
|
LGTM, modulo docs, which could be this OR in the followup. |
|
LGTM. |
dchen1107
added a commit
that referenced
this pull request
Feb 6, 2015
Modify Event struct to allow compressing multiple recurring events in to a single event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
types.gomodify theEvent structto:TimestamptoInitialTimestampLastSeenTimeStampfield (by default it will have the same value asInitialTimeStamp)Countfield (by default it will be 1)This implements the second item from the design proposal in #4073, compressing duplicate events.